Skip to content

more changes for 11-01 from 10-01#2262

Merged
sergey-shandar merged 1 commit intoAzure:masterfrom
chandrasekarsrinivasan:MissedchangesIn1101
Jan 12, 2018
Merged

more changes for 11-01 from 10-01#2262
sergey-shandar merged 1 commit intoAzure:masterfrom
chandrasekarsrinivasan:MissedchangesIn1101

Conversation

@chandrasekarsrinivasan
Copy link
Contributor

@chandrasekarsrinivasan chandrasekarsrinivasan commented Jan 12, 2018 •
edited by azuresdkci
Loading

This checklist is used to make sure that common issues in a pull request are addressed. This will expedite the process of getting your pull request merged and avoid extra work on your part to fix issues discovered during the review process.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes.
  • Swagger files are correctly named (e.g. the api-version in the path should match the api-version in the spec).

Quality of Swagger

@sergey-shandar sergey-shandar added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required potential-sdk-breaking-change labels Jan 12, 2018
@AutorestCI AutorestCI mentioned this pull request Jan 12, 2018
Closed
@azuresdkciprbot
Copy link

azuresdkciprbot commented Jan 12, 2018

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@chandrasekarsrinivasan
Copy link
Contributor Author

chandrasekarsrinivasan commented Jan 12, 2018 •
edited
Loading

Our 11-01 (#2203) got merged in parallel to and hence changes for #2223. Hence never made it to our 11-01. The following PR is to add the changes to 11-01

@sergey-shandar
Copy link
Contributor

sergey-shandar commented Jan 12, 2018

Also see this merge PR #2203

@sergey-shandar
Copy link
Contributor

sergey-shandar commented Jan 12, 2018

The changes are the same as in 2017-10-01.

sergey-shandar
sergey-shandar suggested changes Jan 12, 2018
View reviewed changes
specification/network/resource-manager/Microsoft.Network/stable/2017-11-01/networkWatcher.json Outdated
Copy link
Contributor

@sergey-shandar sergey-shandar Jan 12, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example has different field TargetResourceGroup instead of TargetResourceGroupName. Please fix the example.

@sergey-shandar sergey-shandar removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Jan 12, 2018
@chandrasekarsrinivasan
Copy link
Contributor Author

chandrasekarsrinivasan commented Jan 12, 2018

@sergey-shandar - Thanks updated with examples also.

@azuresdkciprbot
Copy link

azuresdkciprbot commented Jan 12, 2018

Hi There,

I am the AutoRest Linter Azure bot. I am here to help. My task is to analyze the situation from the AutoRest linter perspective. Please review the below analysis result:

File: specification/network/resource-manager/readme.md
Before the PR: Warning(s): 0 Error(s): 85
After the PR: Warning(s): 0 Error(s): 85

AutoRest Linter Guidelines | AutoRest Linter Issues | Send feedback

Thanks for your co-operation.

@sergey-shandar sergey-shandar merged commit ee96cf2 into Azure:master Jan 12, 2018
@AutorestCI AutorestCI mentioned this pull request Jan 12, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 12, 2018

Build Status Azure/azure-sdk-for-ruby#1238

@AutorestCI AutorestCI mentioned this pull request Jan 12, 2018
Closed
@AutorestCI
Copy link

AutorestCI commented Jan 12, 2018

Build Status Azure/azure-sdk-for-python#1779

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@sergey-shandar sergey-shandar sergey-shandar approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sergey-shandar sergey-shandar

Labels

potential-sdk-breaking-change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@chandrasekarsrinivasan @azuresdkciprbot @sergey-shandar @AutorestCI @anuchandy